Fix android phone authentication #308
Conversation
| @@ -104,6 +101,9 @@ actual class PhoneAuthProvider(val android: com.google.firebase.auth.PhoneAuthPr | |||
| } | |||
| } | |||
|
|
|||
| override fun onCodeAutoRetrievalTimeOut(verificationId: String) { | |||
| } | |||
There was a problem hiding this comment.
we'll need to fail the CompletableDeferred here too otherwise it will hang?
There was a problem hiding this comment.
I do not think we should make a response.complete() in onCodeAutoRetrievalTimeOut(), because the response can be completed only once and we would not be able to make response.complete() after user input when onCodeAutoRetrievalTimeOut() is called before.
Maybe we could add a function inside PhoneVerificationProvider: onCodeAutoRetrievalTimeOut()?
There was a problem hiding this comment.
you don't want to complete, you fail it with the appropriate exception
| @@ -104,6 +101,9 @@ actual class PhoneAuthProvider(val android: com.google.firebase.auth.PhoneAuthPr | |||
| } | |||
| } | |||
|
|
|||
| override fun onCodeAutoRetrievalTimeOut(verificationId: String) { | |||
| } | |||
|
|
|||
| override fun onVerificationCompleted(credential: com.google.firebase.auth.PhoneAuthCredential) { | |||
| response.complete(Result.success(AuthCredential(credential))) | |||
There was a problem hiding this comment.
i know this isnt your code but we shoudlnt be wrapping the result in a Result - can just fail the CompletableDeferred with completeExceptionally
There was a problem hiding this comment.
So instead of response.complete(Result.failure(exception)) we should do response.completeExceptionally(exception)?
Hello, sorry for the late reply! |
Current behavior blocks sms code user input until auto retrieval timeout is reached.
Documentation states it is not recommended to enable user input after sms code retrieval timeout, we should rather enable user input after code sent.
https://firebase.google.com/docs/auth/android/phone-auth#oncodeautoretrievaltimeoutstring-verificationid
So I moved the
getVerificationCode()fromonCodeAutoRetrievalTimeOut()toonCodeSent()and it works well on my project.